-
Notifications
You must be signed in to change notification settings - Fork 285
fix: prevent user interaction during operations #7833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Can I have your input on this, please |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
src/views/EditFull.vue
Outdated
| left: 0; | ||
| right: 0; | ||
| bottom: 0; | ||
| background-color: rgba(255, 255, 255, 0.95); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| background-color: rgba(255, 255, 255, 0.95); | |
| background-color: rgba(var(--backdrop-color), 0.5); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
src/views/EditFull.vue
Outdated
| // Dark mode support | ||
| @media (prefers-color-scheme: dark) { | ||
| .edit-full__loading-overlay { | ||
| background-color: rgba(0, 0, 0, 0.95); | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| // Dark mode support | |
| @media (prefers-color-scheme: dark) { | |
| .edit-full__loading-overlay { | |
| background-color: rgba(0, 0, 0, 0.95); | |
| } | |
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
GVodyanov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! We have standard colors for this tho
Thanks! Let wait to see what design thinks of this... |
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
e4223cd to
62585ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as for #7832: #7832 (comment)
Summary